Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unnecessary Object.assign from createResolvable() #3548

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Drop unnecessary Object.assign from createResolvable() #3548

merged 1 commit into from
Dec 25, 2019

Conversation

kevinkassimo
Copy link
Contributor

Remove unnecessary Object.assign from createResolvable()

While this looks like a small change, resolvable promises are way too common such that this single Object.assign can take ~1% in flamegraph

ry
ry approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your detailed write up too.

LGTM

@ry ry merged commit 43fb24f into denoland:master Dec 25, 2019
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@kevinkassimo @bartlomieju
Drop unnecessary Object.assign from createResolvable() (denoland#3548)
5fcedc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinkassimo @ry