Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use sync ops when clearing the console #3533

Merged
merged 2 commits into from
Dec 21, 2019
Merged

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #3532.

cc @dev-nicolaos

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ry ry merged commit f4f4c6b into denoland:master Dec 21, 2019
@dev-nicolaos
Copy link
Contributor

Wow! Like 8 hours from report to merged fix! 👏

@nayeemrmn nayeemrmn deleted the console-sync branch December 21, 2019 12:37
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console.clear is not synchronous
3 participants