Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prettier in //third_party/node_modules #353

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 9, 2018

  • Added prettier dependency in package.json
  • Changed to use local version of prettier in format.py.
  • Changed to use .prettierignore for ignoring certain files.

@ry
Copy link
Member

ry commented Jul 9, 2018

Thanks! Looks good - but can you use the --ignore-path CLI option instead of a separate file?

@kt3k
Copy link
Member Author

kt3k commented Jul 9, 2018

--ignore-path seems for setting the path of .prettierignore file, not for setting the script path to ignore. I don't find an option to do that in prettier's document...

If we need to avoid .prettierignore, I think we need to do something like:

prettier_targets = glob("js/*.js") + glob("js/*.ts")
prettier_targets.remove("js/msg_generated.ts")
prettier_targets.remove("js/flatbuffers.js")

Do you think it's better than using .prettierignore?

If the separate config file seems a little implicit, how about mentioning it in format.py?

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry
Copy link
Member

ry commented Jul 9, 2018

Ok nevermind - thanks for researching it.

@ry ry merged commit 46db201 into denoland:master Jul 9, 2018
@kt3k kt3k deleted the feature/local-prettier branch August 14, 2018 14:30
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants