Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show detailed version with --version flag #3507

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Show detailed version with --version flag #3507

merged 1 commit into from
Dec 15, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 15, 2019

This PR addresses a TODO in //cli/flags.rs. This PR calls long_version of clap::App struct and shows TS/V8 versions with --version option.

$ ./target/debug/deno -V
deno 0.26.0
$ ./target/debug/deno --version
deno 0.26.0
v8 8.0.192
typescript 3.7.2

ry
ry approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 3115781 into denoland:master Dec 15, 2019
@kt3k kt3k deleted the feature/long-version branch December 15, 2019 14:14
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@kt3k @bartlomieju
feat: show detailed version with --version (denoland#3507)
f649a8a
@kt3k kt3k mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kt3k @ry