fetch support URL instance as input #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The URL implementation was never designed to strictly follow the spec, as it has a lot of obtuse/unnecessary logic. We have just been adjusting it when we hit a case where the behaviour causes problems. |
|
/cc @ry It's ready fo review |
dnalborczyk
added a commit
to dnalborczyk/deno
that referenced
this pull request
Dec 19, 2019
This reverts commit 83f95fb.
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW, the URL implementation does not meet the specification
ref:
https://url.spec.whatwg.org/#api
https://w3c.github.io/FileAPI/#creating-revoking