Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v8-options from manual, add v8-flags example #3470

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Remove v8-options from manual, add v8-flags example #3470

merged 2 commits into from
Dec 12, 2019

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 9, 2019 •
edited
Loading

fixes the manual for: #3389

removed the gist link https://gist.github.com/ry/a610ce48cba2f0225f9c81a5a833fc87 as it points to something else.

took me a while to figure out on how to apply an option or multiple options, since there is no feedback when applied wrong.

$ deno --v8-flags=foo-bar  # no error
$ deno --v8-flags=--foo-bar  # no error

@claassistantio
Copy link

claassistantio commented Dec 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ry
Copy link
Member

ry commented Dec 12, 2019

Looks good - thank you!
Sorry we had a problem with windows build being flaky - could you please merge master branch?

@dnalborczyk dnalborczyk reopened this Dec 12, 2019
ry
ry approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit ef17488 into denoland:master Dec 12, 2019
@dnalborczyk dnalborczyk deleted the manual branch December 12, 2019 14:53
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@dnalborczyk @bartlomieju
fix v8-flags example to manual (denoland#3470)
c536068
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@dnalborczyk @ry
fix v8-flags example to manual (denoland/deno#3470)
7a29233
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@dnalborczyk @ry
fix v8-flags example to manual (denoland/deno#3470)
33d9d1e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@dnalborczyk @caspervonb
fix v8-flags example to manual (denoland/deno#3470)
3b0d469
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@dnalborczyk @caspervonb
fix v8-flags example to manual (denoland/deno#3470)
43b7e0b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@dnalborczyk @caspervonb
fix v8-flags example to manual (denoland/deno#3470)
d3e99bd
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@dnalborczyk @caspervonb
fix v8-flags example to manual (denoland/deno#3470)
838f8a1
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@dnalborczyk @caspervonb
fix v8-flags example to manual (denoland/deno#3470)
391add5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@dnalborczyk @denobot
fix v8-flags example to manual (denoland/deno#3470)
c8eb696
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@dnalborczyk @denobot
fix v8-flags example to manual (denoland/deno#3470)
95ae403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnalborczyk @claassistantio @ry