Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_server prints errors in console #3467

Merged
merged 8 commits into from
Dec 12, 2019
Merged

file_server prints errors in console #3467

merged 8 commits into from
Dec 12, 2019

Conversation

zhmushan
Copy link
Contributor

@zhmushan zhmushan commented Dec 9, 2019

cc @kitsonk
close: #3465

std/http/file_server.ts Outdated Show resolved Hide resolved
@zhmushan zhmushan changed the title fix(file_server): throw permission denied error file_server prints errors in console Dec 9, 2019
std/http/file_server.ts Outdated Show resolved Hide resolved
@zhmushan
Copy link
Contributor Author

zhmushan commented Dec 9, 2019

why ci red?
It seems to fail where I haven't modified.

@axetroy
Copy link
Contributor

axetroy commented Dec 9, 2019

why ci red?
It seems to fail where I haven't modified.

Try to run CI again with empty commit

git commit -m "trigger ci" --allow-empty

std/http/file_server_test.ts Outdated Show resolved Hide resolved
@ry
Copy link
Member

ry commented Dec 12, 2019

Hi @zhmushan - there's a conflict, could you please merge master? Otherwise looks good. Thank you!

@zhmushan
Copy link
Contributor Author

@ry done

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 7f27f64 into denoland:master Dec 12, 2019
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http/file_server broken
4 participants