Generate //third_party/ and the symlinks from the script. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
approved these changes
Jul 8, 2018
There was a problem hiding this comment.
Excellent work. Thanks for pushing this forward, @kt3k ! We're almost to a deno_third_party git submodule now.
I'd like to leave the task of creating common utilities for later work because the layout of scripts seems inconvenient to do it
sounds good!
LGTM
mayfieldiv
reviewed
Jul 9, 2018
| os.unlink(name) | ||
| except: | ||
| pass | ||
| os.symlink(target, name) |
There was a problem hiding this comment.
It seems like this line should be symlink(target, name). Otherwise, the symlink function below is unused.
There was a problem hiding this comment.
Thanks for catching it. That seems fixed now in master https://github.com/ry/deno/blob/master/tools/util.py#L25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the comment of Ryan in #328.
The script now creates
//third_party/and sets up the symlinks in it, and then updates all gclient and npm deps.I copied
symlinkfunction from//js/run_node.pyfor now. I'd like to leave the task of creating common utilities for later work because the layout of scripts seems incovenient to do it.If this PR is merged, everyone needs to run
./tools/build_third_party.pyagain.