fix: isolate tests #3459
Merged
fix: isolate tests #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d0b4e5
to
1ca3dc1
Compare
ry
reviewed
Dec 7, 2019
ry
approved these changes
Dec 7, 2019
There was a problem hiding this comment.
LGTM
Good catch @kevinkassimo and thanks for the quick fix @bartlomieju. It's scary that such errors can get past CI. I wish I had a way to tell rust to quit the process when any thread panics.
|
@ry TIL you could use |
|
@95th We had that before but it actually caused other problems - like not being able to see stack traces. Here are some references: |
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Dec 28, 2019
Some tests were silently failing after denoland#3358 and denoland#3434 because pool.spawn_ok was used which doesn't panic on errors. For reference, the failure looked like this: thread '<unnamed>' panicked at 'assertion failed: match isolate.poll_unpin(cx) { Poll::Ready(Ok(_)) => true, _ => false, }', core/isolate.rs:1408:7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Isolate tests as pointed by @kevinkassimo in Gitter.
I screwed it up during #3358 and #3434 because I used
pool.spawn_okwhich doesn't panic on errors.