Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicated argv member from ThreadSafeGlobalState #3433

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

ry
Copy link
Member

@ry ry commented Dec 2, 2019

Continuation of work from #3389

@ry ry requested a review from piscisaureus December 2, 2019 19:13
Comment on lines +66 to +67
/// Vector of CLI arguments - these are user script arguments, all Deno
/// specific flags are removed.
Copy link
Member

@bartlomieju bartlomieju Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer true? deno run --allow-net foo.ts --allow-run --allow-write should give argv == vec!["foo.ts", "--allow-run", "--allow-write"].

So Deno specific flags are removed only when before script name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s right but I think the comment is still more or less correct?

@ry ry merged commit ee01310 into denoland:master Dec 3, 2019
@ry ry deleted the argv branch December 3, 2019 22:23
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants