refactor: remove duplicated argv member from ThreadSafeGlobalState #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Dec 2, 2019
Comment on lines
+66
to
+67
| /// Vector of CLI arguments - these are user script arguments, all Deno | ||
| /// specific flags are removed. |
There was a problem hiding this comment.
No longer true? deno run --allow-net foo.ts --allow-run --allow-write should give argv == vec!["foo.ts", "--allow-run", "--allow-write"].
So Deno specific flags are removed only when before script name.
There was a problem hiding this comment.
That’s right but I think the comment is still more or less correct?
piscisaureus
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of work from #3389