Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix realpath behavior in windows #3425

Merged
merged 2 commits into from
Dec 1, 2019
Merged

fix realpath behavior in windows #3425

merged 2 commits into from
Dec 1, 2019

Conversation

zhmushan
Copy link
Contributor

@zhmushan zhmushan commented Nov 30, 2019 •
edited
Loading

fixed #3424

@zhmushan zhmushan changed the title fix realpath fix realpath behavior in windows Dec 1, 2019
ry
ry approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I’m not sure exactly why fs::canonicalize has this behavior on windows - it’s been a problem for us in the past.

@ry ry merged commit 537c6b3 into denoland:master Dec 1, 2019
@zhmushan zhmushan deleted the fix_realpath branch December 1, 2019 22:57
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@zhmushan @bartlomieju
fix realpath behavior in windows (denoland#3425)
5810419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] windows: Deno.realpath
2 participants
@zhmushan @ry