Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: Tokio 0.2 #3418

Merged
merged 39 commits into from
Dec 30, 2019
Merged

upgrade: Tokio 0.2 #3418

merged 39 commits into from
Dec 30, 2019

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Nov 28, 2019

This PR upgrades Tokio version in CLI.

There are currently two pending issues:

  • new tokio::fs::File doesn't expose .into_std() method, which means file cannot be passed to subprocess as stdio (fixed in Tokio 0.2.2)
  • awaiting reqwest update, ie. fetch API doesn't work yet

Ref #3387, tokio-rs/tokio#1852

cli/Cargo.toml Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

FYI: I hit some problems upgrading reqwest due to API changes there (Decoder which we use to implement HttpBody resource is no longer available). Anyway, still waiting on reqwest release, I'll coordinate with them to make this work.

@bartlomieju bartlomieju requested a review from ry December 27, 2019 19:01
@bartlomieju
Copy link
Member Author

reqwest is close to 0.10.0 release

cli/http_util.rs Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this! Please add TODOs and/or an issue describing the flush situation. It's not ideal - but I think we all agree that this needs to land. Otherwise LGTM.

@bartlomieju bartlomieju merged commit 46d76a7 into denoland:master Dec 30, 2019
@bartlomieju bartlomieju deleted the upgrade-tokio_02 branch December 30, 2019 13:57
@95th
Copy link
Contributor

95th commented Jan 1, 2020

This PR has reduced the no. of syscalls
Annotation 2020-01-01 202239

There is also increase of one thread (Perhaps this is temporary due to uses of block_on at various places).
Annotation 2020-01-01 202239 2

@bartlomieju bartlomieju mentioned this pull request Jan 2, 2020
@hayd
Copy link
Contributor

hayd commented Jan 3, 2020

Did this add native-tls as a requirement (in hyper?). It seems like openssl is now required (at least to build) on Amazon Linux, where previously we were using rustls?
https://github.com/hayd/deno-docker/runs/371640720

In the docs: https://hyper.rs/guides/client/configuration/

This means that you could pick a different TLS implementation than the one chosen by hyper-tls, such as rustls.

But I'm not really sure how!

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants