Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deno_core_http_bench to Tokio 0.2 #3408

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

bartlomieju
Copy link
Member

No description provided.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Let’s see how it performs

@ry ry merged commit 866dba8 into denoland:master Nov 27, 2019
@ry
Copy link
Member

ry commented Nov 27, 2019

This seems to have caused a regression in the http benchmarks for deno_core_multi 60k req/sec -> 40k

@bartlomieju bartlomieju deleted the upgrade-tokio_deno_core branch November 27, 2019 09:52
ry added a commit to ry/deno that referenced this pull request Nov 27, 2019
It seems this has caused CI to go red for an unknown reason.

This reverts commit 866dba8.
@ry
Copy link
Member

ry commented Nov 27, 2019

CI seems to have gone red after this PR. The errors do not seem related but I'm going to roll it back anyway: #3414

ry added a commit that referenced this pull request Nov 27, 2019
It seems this has caused CI to go red for an unknown reason.

This reverts commit 866dba8.
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
It seems this has caused CI to go red for an unknown reason.

This reverts commit 866dba8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants