Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove tokio_util::block_on from ops/workers.rs #3381

Merged
merged 1 commit into from
Nov 20, 2019
Merged

refactor: remove tokio_util::block_on from ops/workers.rs #3381

merged 1 commit into from
Nov 20, 2019

Conversation

bartlomieju
Copy link
Member

Yet another attempt to bring thread count down for workers. If this proves useful I might abstract it away and reuse in file_fetcher.rs

@bartlomieju
Copy link
Member Author

Oh yes

"thread_count": {
    "error_001": 4, 
    "text_decoder": 3, 
    "cold_relative_import": 5, 
    "cold_hello": 4, 
    "workers_round_robin": 4, 
    "relative_import": 3, 
    "workers_startup": 4, 
    "hello": 3
  },

I'm factoring it out

@bartlomieju
Copy link
Member Author

Unfortunately this solution is not universally usable... It does not work with --current-thread option 😢

ry
ry approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 1912ed6 into denoland:master Nov 20, 2019
@bartlomieju bartlomieju deleted the refactor-remove_block_on branch December 2, 2019 13:22
@kevinkassimo kevinkassimo mentioned this pull request Dec 11, 2019
Closed
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@bartlomieju
remove tokio_util::block_on from ops/workers.rs (denoland#3381)
9b17a0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry