Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize symlinks #338

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Reorganize symlinks #338

merged 2 commits into from
Jul 6, 2018
+3,663 −3,661

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 6, 2018

  • Changed the node_modules symlink in build dir point to //third_party/node_modules
  • Moved //js/package.json to //package.json
  • Moved //third_party/yarn.lock to //yarn.lock
  • Made a symlink from //node_modules to //third_party/node_modules
  • Removed the symlink //js/node_modules -> //third_party/node_modules/ (seems unnecesary now)
  • Updated the reference of package.json in //BUILD.gn

resolves #332

ry
ry reviewed Jul 6, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yoshiya!

Can you use git mv third_party/yarn.lock yarn.lock?
I think it got changed.

@kt3k
Copy link
Member Author

kt3k commented Jul 6, 2018

If I move //third_party/yarn.lock to //yarn.lock and create the symlink //third_party/yarn.lock at the same time, git seems recognizing it as changed, instead of renamed. I separated those operations into 2 commits ry@78e48ae and ry@a0874fb, but the entire (PR's) diff seems the same.

ry
ry approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@ry ry merged commit 1f6f2f5 into denoland:master Jul 6, 2018
@kt3k kt3k deleted the feature/reorg-symlinks branch July 6, 2018 11:42
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@zekth @ry
http : Add cookie module (denoland#338)
1d85447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move js/node_modules
2 participants
@kt3k @ry