Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidates asserts#equal branches for keyed collections (Map/Set) and supports deep equality of Map keys #3258

Merged
merged 13 commits into from
Nov 4, 2019
Merged

Consolidates asserts#equal branches for keyed collections (Map/Set) and supports deep equality of Map keys #3258

merged 13 commits into from
Nov 4, 2019

Commits on Nov 3, 2019

  1. Adds array test cases for asserts#equal

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    e560e70 View commit details
    Browse the repository at this point in the history

  2. Implements common deep equality logic for keyed collections

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    06668ae View commit details
    Browse the repository at this point in the history

  3. Declares type for keyed collections

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    6b3e73f View commit details
    Browse the repository at this point in the history

  4. Replaces duck typing with explicit instanceof operators for consistency

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    23c8a45 View commit details
    Browse the repository at this point in the history

  5. Formats asserts changes

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    6951b6a View commit details
    Browse the repository at this point in the history

  6. Supports deep equality of Map and Set keys

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    a67eb30 View commit details
    Browse the repository at this point in the history

  7. Inverts condition for keyed collection entry matching

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    71f1cd3 View commit details
    Browse the repository at this point in the history

  8. Formats changes

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    3b5c42b View commit details
    Browse the repository at this point in the history

  9. Tweaks assertion in test

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    d104913 View commit details
    Browse the repository at this point in the history

  10. Removes superfluous line breaks

    @jamesseanwright
    jamesseanwright committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    6f4de57 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Adds key-value strict equality check to avoid double-verification of … 

    …Sets
    @jamesseanwright
    jamesseanwright committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    4a42219 View commit details
    Browse the repository at this point in the history

  2. Tweaks comment

    @jamesseanwright
    jamesseanwright committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    5aec22b View commit details
    Browse the repository at this point in the history

  3. Reverts third_party submodule update

    @jamesseanwright
    jamesseanwright committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    db90fef View commit details
    Browse the repository at this point in the history