Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EOF symbol #3244

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Make EOF symbol #3244

merged 2 commits into from
Oct 31, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Oct 31, 2019

At the time of #2591, it was not possible to make EOF an unique symbol, but it now seems possible to do it.

This addresses a TODO comment in //cli/js/io.ts.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 4f8c936 into denoland:master Oct 31, 2019
@kt3k kt3k deleted the feature/symbol-eof branch October 31, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants