Support for deep Map equality with asserts#equal
#3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesseanwright
commented
Oct 29, 2019
std/testing/asserts.ts
Outdated
| messages.push(c(`${createSign(result.type)}${result.value}`)); | ||
| } | ||
| ); | ||
| diffResult.forEach((result: DiffResult<string>): void => { |
There was a problem hiding this comment.
Strangely, this unrelated block seems to have been changed when formatting this module. Shall I revert this? I appreciate it's a bit misleading given it isn't directly related to my changes.
There was a problem hiding this comment.
Disregard. This was a symptom of my using deno fmt directly slaps self on wrist.
|
|
|
Noticed the lint check is failing. I'll take a look shortly. |
Looks like I've fixed it. |
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3235, here is my fix for supporting for deeply comparing
Mapinstances in theassertsmodule'sequalfunction. Much like the conditional branches forSetcomparisons, this logic has been inlined withinequalitself.I've also included a set of test cases (simple equality, nested
Maps , arrays and objects asMapvalues etc.)