Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TTY tests - dead code #3229

Merged
merged 5 commits into from
Oct 29, 2019
Merged

Remove TTY tests - dead code #3229

merged 5 commits into from
Oct 29, 2019

Conversation

ry
Copy link
Member

@ry ry commented Oct 29, 2019

tools/*permission_tests.* have been dead code for awhile, but recently we even removed the interactive prompt they were testing (#3183). Let's just remove all this dead code now - although I believe this introduces a gap in our test coverage of permissions.

cc @afinch7 @kt3k

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry requested a review from piscisaureus October 29, 2019 02:06
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ry ry merged commit 8f571ef into denoland:master Oct 29, 2019
@ry ry deleted the remove_tty_tests branch October 29, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants