Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deno.listenTLS #3152

Merged
merged 14 commits into from
Oct 21, 2019
Merged

feat: Deno.listenTLS #3152

merged 14 commits into from
Oct 21, 2019

Conversation

bartlomieju
Copy link
Member

Towards #3009

@bartlomieju
Copy link
Member Author

Update: I got listenTLS and dialTLS to work together using self signed root certificate. I still need to clean it up and write better test 💪

@bartlomieju bartlomieju changed the title [WIP] feat: Deno.listenTLS feat: Deno.listenTLS Oct 19, 2019
@bartlomieju
Copy link
Member Author

@ry ready for review

ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/js/lib.deno_runtime.d.ts Outdated Show resolved Hide resolved
ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/js/tls.ts Outdated Show resolved Hide resolved
ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/js/tls_test.ts Outdated Show resolved Hide resolved
ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/ops/tls.rs Outdated Show resolved Hide resolved
ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/tests/tls/README Outdated Show resolved Hide resolved
ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/js/tls_test.ts Outdated Show resolved Hide resolved
ry
ry reviewed Oct 21, 2019
View reviewed changes
cli/js/tls_test.ts Show resolved Hide resolved
ry
ry approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - massive feature @bartlomieju !

Thank you on behalf of everyone who wants to run a TLS server in Deno : )

@ry ry merged commit 6c5a981 into denoland:master Oct 21, 2019
@bartlomieju bartlomieju deleted the feat-listen_tls branch October 21, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry