Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg step2 #309

Merged
merged 5 commits into from
Jul 1, 2018
Merged

Reorg step2 #309

merged 5 commits into from
Jul 1, 2018

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 1, 2018

I tried the step 2 of #285. I moved things like the below:

//src/BUILD.gn -> //BUILD.gn
//src/.gn -> //.gn
//src/.gclient -> //.gclient
//src/deno.gni -> //deno.gni
//src/v8 -> //v8
//src/build -> //build
//src/build_overrides -> //build_overrides
//src/buildtools -> //buildtools
//src/testing -> //testing
//src/tools/clang -> //tools/clang
//src/third_party/googletest -> //third_party/googletest
//src/third_party/jinja2 -> //third_party/jinja2
//src/third_party/llvm-build -> //third_party/llvm-build
//src/third_party/markupsafe -> //third_party/markupsafe

I updated the build instructions as well.
I was able to build out/Debug/deno with this change.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is very helpful and perfectly executed.

(ccache is not necessary, but I'll land that comment anyway)

@ry ry merged commit 6830370 into denoland:master Jul 1, 2018
@kt3k
Copy link
Member Author

kt3k commented Jul 1, 2018

Thank you for landing! It's an honor 😃

@kt3k kt3k deleted the feature/reorg-step2 branch July 1, 2018 12:03
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
…enoland#309)

- Fix the type of macro argument (was `ident` but should be `ty`)
- Tweak how we get the address of the static to be slightly less unsafe
(not really an issue, miri didn't complain just saw it)
- Use the correct type for external usage (no external package -- just
deno_core crate root)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants