Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge std #3085

Closed
wants to merge 399 commits into from
Closed

Merge std #3085

wants to merge 399 commits into from

Conversation

piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented Oct 7, 2019 •
edited
Loading

TODO

  • format
  • get lint to pass
  • run tests in github actions

Dmitry Sharshakov and others added 30 commits February 19, 2019 09:58
@ry
Bump CI to v0.3 (denoland#204)
37a6bca
@ry
Revert "Redesign of http server module (denoland#188)"
57c9176 
We need to consider the API changes here more carefully.

This reverts commit da188a7.
and commit 8569f15.
@manyuanrong @ry
Fixed non-standard prefix on importing (denoland#216)
f65fda8
@bartlomieju @ry
Add runIfMain method (denoland#215)
817a0fb
@hayd @ry
Clean up the test failure output (denoland#209)
e609f0c
@ry @piscisaureus
Fix import in http_bench.ts (denoland#217)
d441a7d
@piscisaureus @ry
Change import { x } from "deno" to const { x } = Deno (denoland#218)
6063378
@ry
Bump CI to v0.3.1 (denoland#220)
93e5e0c
@zekth @ry
Glob integration for the FS walker (denoland#219)
0c3ba83
@zekth @ry
Testing add ansi color support from color module (denoland#223)
90871cf
@zekth @ry
fs.walk performance improvement (denoland#221)
ccb452f
@zekth @ry
fixing readme link + version (denoland#225)
0ba93a9
@zekth @ry
Re-enabling colors after color testing (denoland#226)
b4fba9f
@zekth @ry
Fixing default parameters of runBenchmarks (denoland#229)
facc8ce
@zekth @ry
Refactoring + Enhance UTs + Enhance doc (denoland#230)
e2fd507
@chiefbiiko @ry
feat: parallel testing (denoland#224)
41bdd09
@ry
Refactor WebSockets (denoland#173)
385f866 
* Use assert.equal instead of deprecated assertEqual
* Replace let with const where possible
* Add WebSocketMessage type
* Use OpCode in WebSocketFrame
* Use const where possible in WS
* Separate sha1 tests, use const instead of let
@kitsonk @ry
Add eslint for linting (denoland#235)
c0390ad
@zekth @ry
Use pretty assertEqual in testing (denoland#234)
8fb9f70
@zekth @ry
Refactor asserts in testing (denoland#227)
c734e32
@EvanHahn @ry
Update mime-db to 1.38.0 (denoland#238)
d430a24 
[email protected] was released on 2019-02-04. This updates the JSON file.
@hayd @ry
Replace deno.land/x/ with deno.land/std/ (denoland#239)
0fc13ff
@zekth @ry
Testing refactor (denoland#240)
e1d5c00
@ry
Rename assertEq to assertEquals (denoland#242)
4cf39d4 
After some discussion it was found that assertEquals is more common
in JS (vs assertEqual, assertEq) and sounds better in the negated form:
assertNotEquals vs assertNE.
@kt3k @ry
Bump CI to v0.3.2 (denoland#245)
c677516 
replace Deno.platform with Deno.build
@zekth @ry
Add assertNotEquals, assertArrayContains (denoland#246)
899ab67
@kt3k @ry
Use Deno global var instead of built-in "deno" module (denoland#247)
3953929
@hayd @ry
Use fs.walk rather than git ls-files (denoland#241)
afaf343
@ry
testing/asserts: Add unimplemented and unreachable (denoland#248)
02274ef
@kt3k @ry
refactor: use execPath where appropriate (denoland#255)
bf76484
keroxp and others added 7 commits September 28, 2019 12:46
@keroxp @ry
feat: wss support with dialTLS (denoland#615)
cac2d5e
@keroxp @ry
fix(ws) mask must not be set by default for server (denoland#616)
de99fcb
@timonson @ry
added type number to 'size' parameter (denoland#618)
f3bdf1a
@nayeemrmn @ry
Implement expandGlob() and expandGlobSync() (denoland#617)
8c90bd9 
fs/glob.ts:
- Improve prototypes for expandGlob() and expandGlobSync() from denoland#604.
- Rename glob() to globToRegExp().
- Add normalizeGlob() and joinGlobs().
- Extract GlobToRegExpOptions from GlobOptions, remove the strict
  and filepath options.

fs/globrex.ts:
- Add GlobrexOptions.

fs/path/constants.ts:
- Add SEP_PATTERN.

fs/walk.ts:
- Add WalkOptions::includeFiles
- Default WalkOptions::includeDirs to true.
- Don't traverse directories matching a skip pattern.
- Remove walkSync()'s default root value.

prettier:
- Refactor to use expandGlob().

testing:
- Make findTestModules() an async generator.
@kt3k @ry
Update eslint and @typescript-eslint (denoland#621)
c3fe858
@bartlomieju @ry
fix: Update echo_server to new listen API (denoland#625)
287fbb5
@piscisaureus
Merge the deno_std submodule into the 'std' subdirectory
c3b40ea
@CLAassistant

This comment has been minimized.

Sign in to view
@ry ry mentioned this pull request Oct 8, 2019
Closed
@piscisaureus piscisaureus requested a review from ry October 8, 2019 01:44
ry
ry approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think we should just land this. I've disabled CLA requirements because deno_std shares the same CLA and the contributor there have signed it.

I will leave it to you, @piscisaureus, to land.

@ry ry mentioned this pull request Oct 8, 2019
Closed
ry
ry requested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're doing further work to change the history and provide links in each deno_std comment to their original discussions. Removing approval status until we review this PR further.

@ry ry mentioned this pull request Oct 9, 2019
Closed
@ry
Copy link
Member

ry commented Oct 9, 2019

Closed in favor of #3091 because

~/src/deno> git log -5 --oneline --follow std/http/server.ts
ddcad56e Move deno_std to a more convenient location. (#3057)
~/src/deno>

@ry ry closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.