[WIP] use wildcard to check test outputs #3
Conversation
wildcard.go
Outdated
|
|
||
| var WILDCARD = []byte("[WILDCARD]") | ||
|
|
||
| func Wildcard(pattern []byte, text []byte) bool { |
There was a problem hiding this comment.
I think this would be better inside the util.go file and tests in util_test.go. And it should be lowercase (not exported).
wildcard_test.go
Outdated
| return Wildcard([]byte(a), []byte(b)) | ||
| } | ||
|
|
||
| func TestWildcard(t *testing.T) { |
integration_test.go
Outdated
| @@ -78,6 +85,7 @@ func deno(inputFn string) (actual []byte, cachedir string, err error) { | |||
| var out bytes.Buffer | |||
| cmd.Stdout = &out | |||
| err = cmd.Run() | |||
| cmd.Wait() | |||
There was a problem hiding this comment.
Yikes. Was this causing a race condition?
Edit: I think this does nothing. Run already waits.
integration_test.go
Outdated
| @@ -57,10 +58,16 @@ func checkOutput(t *testing.T, outFile string) { | |||
| } | |||
|
|
|||
| actual, _, err := deno(jsFile) | |||
| fmt.Println(jsFile) | |||
| fmt.Println(string(actual)) | |||
|
@ry there is a bug which lays down somewhere else rather than this pr, the test result shows that |
|
|
There was a problem hiding this comment.
I've solved the bug you were having and made some other fix ups - pushed to your branch: qti3e/deno@d26704a
I will squash it all into one commit when landing.
Thanks Parsa!
util.go
Outdated
|
|
||
| var WILDCARD = []byte("[WILDCARD]") | ||
|
|
||
| func wildcard(pattern []byte, text []byte) bool { |
There was a problem hiding this comment.
I think this should operate on strings instead of byte arrays?
|
My pleasure Ryan! (thanks for fixups btw!) |
No description provided.