Tools cleanup #2950
Merged
Tools cleanup #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
force-pushed
the
tools_cleanup
branch
3 times, most recently
from
f0590fa
to
4cd87e8
Compare
chrmoritz
reviewed
Sep 14, 2019
tools/format.py
Outdated
| @@ -15,6 +14,8 @@ | |||
| parser.add_argument("--gn", help="only run gn format", action="store_true") | |||
| parser.add_argument("--cc", help="only run clang format", action="store_true") | |||
|
|
|||
| clang_format_path = os.path.join(third_party_path, "depot_tools", | |||
| "clang-format") | |||
There was a problem hiding this comment.
Could we directly call clang_format.py with sys.executable here instead of the wrapper script?
There was a problem hiding this comment.
It is possible, but the way it was done in #2943 did not work for me (on windows).
Also, if bypassing wrapper scripts is a goal, then IMO we should just call the clang_format binary directly.
The clang_format.py wrapper creates more problems than it solves.
There was a problem hiding this comment.
Oh, but without it I've seen strange build errors on appveyor like: https://ci.appveyor.com/project/deno/deno/builds/27388163#L329. But unfortunately I can't test it by myself on Windows, so it's quite hard to debug for me.
There was a problem hiding this comment.
IMHO calling the clang-format binary directly seems to be a good option for me, because otherwise after the gn root move to core/libdeno we would need to either set CHROMIUM_BUILDTOOLS_PATH or maintain 2 buildtools symlinks, see: #2943 (comment)
|
This PR is not complete yet. I also have some updates to format.py and lint.py in the pipeline |
piscisaureus
force-pushed
the
tools_cleanup
branch
from
4cd87e8
to
b1a121d
Compare
chrmoritz
reviewed
Sep 14, 2019
piscisaureus
force-pushed
the
tools_cleanup
branch
11 times, most recently
from
f3553f8
to
39506ed
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
…nd#2950) * Remove reference to removed dir 'third_party/rust_crates'. * Remove reference to unused environment variable 'DENO_NINJA_PATH'. * Remove helper functions 'root()' and 'tp()'. * Move definition of 'third_party_path' to build.py. * Move definition of 'gn_exe()' to setup.py. * Move 'download_sccache()' and 'download_hyperfine()' from prebuilt.py to third_party.py, and delete prebuilt.py. * Add helper function 'get_platform_dir_name()' to locate the platform-specific 'v8/buildtools/<platform>' and 'prebuilt/<platform>' directories. * Add helper function 'get_prebuilt_tool_path()' that returns the full path to a platform-specific executable in //prebuilt. * Cosmetic improvements.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
force-pushed
the
tools_cleanup
branch
from
39506ed
to
f9b8a85
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
force-pushed
the
tools_cleanup
branch
from
f9b8a85
to
0abe078
Compare
…nd#2950) * Remove reference to removed dir 'third_party/rust_crates'. * Remove reference to unused environment variable 'DENO_NINJA_PATH'. * Remove helper functions 'root()' and 'tp()'. * Move definition of 'third_party_path' to build.py. * Move definition of 'gn_exe()' to setup.py. * Move 'download_sccache()' and 'download_hyperfine()' from prebuilt.py to third_party.py, and delete prebuilt.py. * Add helper function 'get_platform_dir_name()' to locate the platform-specific 'v8/buildtools/<platform>' and 'prebuilt/<platform>' directories. * Add helper function 'get_prebuilt_tool_path()' that returns the full path to a platform-specific executable in //prebuilt. * Cosmetic improvements.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Sep 15, 2019
piscisaureus
force-pushed
the
tools_cleanup
branch
from
0abe078
to
25b4e76
Compare
piscisaureus
force-pushed
the
tools_cleanup
branch
from
25b4e76
to
4556a38
Compare
chrmoritz
pushed a commit
to chrmoritz/deno
that referenced
this pull request
Sep 15, 2019
This was referenced Sep 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be done to make landing #2943 more manageable