-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish cli crate #2946
Publish cli crate #2946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't see any updates to cargo_package.py. Am I missing something? |
- Fixes cargo publish on deno_typescript, deno_cli_snapshots, and deno_cli. - Combines cli_snapshots and js into one directory. - Extracts TS version at compile time rather than runtime - Bumps version awkwardly - it was necessary to test end-to-end publishing. Sorry. - Adds git submodule deno_typescript/typescript
So, the other crates (deno_cli, deno_typescript, deno_cli_snapshots) are able to be published with just "cargo publish". I think we should leave to cargo_package.py as it is, because it's doing a particular hack... I could add tools/cargo_publish_others.py (or something) that simply ran cargo publish in the various directories? But I think there are more clean ups to happen still in this area (in particular i want to still rename the crates so we can have 'cargo install deno' work), and I would just as well put that off for a while. |
Ok, that's great. I was mainly looking for it to understand what the release procedure looks like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand what the release procedure is after this, maybe add some explanation (see #2946 (comment)).
But it seems to work so go ahead and land.
I've added We should probably also be running this with the |
Try:
cargo install deno_cli
Towards #2942