Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @typescript-eslint/* to v2.1.0 #2878

Merged
merged 3 commits into from
Sep 7, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 7, 2019

This PR updates @typescript-eslint toolchains to v2.1.0. This removes the below warning from ./tools/lint.py:

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.

depends on denoland/deno_third_party#50

@kt3k kt3k force-pushed the feature/update-typecript-eslint branch from 15f956a to 4d627bd Compare September 7, 2019 11:47
let index = numRecords();
const off = head();
const end = off + buf.byteLength;
const index = numRecords();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - I guess this wasn't being checked before?

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Awesome thank you @kt3k

@ry ry merged commit f12acdb into denoland:master Sep 7, 2019
@kt3k kt3k deleted the feature/update-typecript-eslint branch September 7, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants