do not export isConsoleInstance

[justjavac]

I saw in the typedoc that isConsoleInstance should not be exported, it is only used inside console.ts.

[bartlomieju]

@justjavac I think this is related to #2649, unfortunately I still can't construct new console (the same error appears). This feature is still wanted especially for test runner

[justjavac]

const c = new Deno.Console(Deno.core.print) ?

[bartlomieju]

I'll get back to you @justjavac I need to update my branch after recent changes to build process

[bartlomieju]

@justjavac so I updated my branch and I still get this error when trying to create new console:

error TS2741: Property '[isConsoleInstance]' is missing in type 'Deno.Console' but required in type 'consoleTypes.Console'.

► file:https:///Users/biwanczuk/dev/deno_std/testing/mod.ts:63:3

63   window.console = fakeConsole;
     ~~~~~~~~~~~~~~

  '[isConsoleInstance]' is declared here.

    ► $asset$/lib.deno_runtime.d.ts:2036:5

    2036     [isConsoleInstance]: boolean;
             ~~~~~~~~~~~~~~~~~~~

Any idea what's wrong? isConsoleInstace is set to true in the constructor of Console....

[ry]

LGTM

[ry]

Can you also remove from js/lib.deno_runtime.d.ts

[justjavac]

done

[ry]

LGTM

[bartlomieju]

@justjavac can you look at this comment? #2850 (comment)

[justjavac]

@bartlomieju I have tried it, it can work

[bartlomieju]

@justjavac can you show a repro? The above error appears when I create new Console instance in deno_std and run it with strict TS checks

[justjavac]

Because of a duplication of type isConsoleInstance. Try to compile deno from the latest master, it can construct the Console instance.

[justjavac]

I will retry it tomorrow.