Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename powershell highlighting to shell #2654

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

justjavac
Copy link
Contributor

In the previous commit(#1780 (comment)), we removed support for PowerShell highlighting, which made the style ugly:

In the manual, we used jsut only one PowerShell code iwr https://deno.land/x/install/install.ps1 -useb | iex, so we can change the highlight name from powershell to shell. It can implement the exact same highlighting style without loading an extra 6kb(ziped 2.93kb) js file.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit a0b8f13 into denoland:master Jul 18, 2019
@justjavac justjavac deleted the hljs-powershell branch July 18, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants