ReadFileToString fix and not using bools in deno.h #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts a unit test for it, and adds to mock_runtime_test.
ry
changed the title
|
|
||
| // Routes message to the javascript callback set with deno_sub(). A false return | ||
| // value indicates error. Check deno_last_exception() for exception text. | ||
| bool deno_pub(Deno* d, const char* channel, deno_buf buf); | ||
| // 0 = fail, 1 = success | ||
| int deno_pub(Deno* d, const char* channel, deno_buf buf); |
There was a problem hiding this comment.
Understandable since this function was returning bool before.
However going forward I'd like to use the common pattern that >= indicates success and <0 means failure.
There was a problem hiding this comment.
Yeah - it bothers me too. I'll change it on the next iteration.
piscisaureus
pushed a commit
to piscisaureus/deno
that referenced
this pull request
Oct 7, 2019
humancalico
pushed a commit
to humancalico/deno
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.