Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt_test: resolve absolute path issue of fmt testing #2562

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 22, 2019

This PR resolves a TODO comment in //tools/fmt_test.py

deno fmt used to has a bug about handling of absolute paths. Now it was fixed at denoland/deno_std#438, and we can use absolute paths in arguments.

@kt3k kt3k changed the title fmt_test: resolve old absolute path issue fmt_test: resolve absolute path issue Jun 22, 2019
@kt3k kt3k changed the title fmt_test: resolve absolute path issue fmt_test: resolve absolute path issue of fmt testing Jun 22, 2019
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 201ddd2 into denoland:master Jun 22, 2019
@kt3k kt3k deleted the feature/resolve-fmt-test-todo branch June 22, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants