refactor: use Path/PathBuf in deno dir #2559
Conversation
This reverts commit 2efca8f.
|
@ry PTAL if this direction is satisfactory. Handling of paths was replaced with use of |
|
CC @kitsonk |
| @@ -27,6 +27,18 @@ use std::str; | |||
| use url; | |||
| use url::Url; | |||
|
|
|||
| fn normalize_path(path: &Path) -> PathBuf { | |||
There was a problem hiding this comment.
Does this even make sense in when using Path and PathBuf instead of String?
I think you should try removing this function entirely.
There was a problem hiding this comment.
I believe it does... PTAL at this comment.
I tried removing this method, but that caused Windows build to start failing.
I'd prefer to normalize all paths to use forwards slashes everywhere in our codebase, just to simplify manipulating for us, std::fs methods are able to use forward slashes appropriately on Windows.
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use tempfile::TempDir; | ||
|
|
||
| fn normalize_to_str(path: &Path) -> String { | ||
| normalize_path(path).to_str().unwrap().to_string() | ||
| } |
There was a problem hiding this comment.
Try removing this... does it still work?
|
@bartlomieju Please merge with master |
|
@ry merged |
This is preliminary work towards #2057
Refactoring
//cli/deno_dir.rsto use more concrete types, because there is a hell lot of&strarguments