New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting non-existent params removes ? from URL #2495

Merged

ry merged 1 commit into denoland:master from justjavac:url-search-params-updating

Jun 11, 2019

Contributor

justjavac commented Jun 11, 2019

const url = new URL("https://example.com/?")
url.searchParams.sort()

// current
url.href === "https://example.com/?"
url.search === "?"

// after fixed
url.href === "https://example.com/"
url.search === ""


          sorting non-existent params removes ? mark

3caf73a

ry approved these changes

View reviewed changes

Member

ry left a comment

LGTM

ry merged commit 0efb7c2 into denoland:master

justjavac deleted the url-search-params-updating branch

June 11, 2019 04:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet