Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #248

Closed
wants to merge 15 commits into from
Closed

Fix #248

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
110ddab
Add deno2 prototype from external repo.
ry Jun 9, 2018
4dbb632
deno2 readme adjustments
ry Jun 9, 2018
f7e9942
deno2: Fix lint
ry Jun 10, 2018
9df9cda
deno2 Simplify Print binding.
ry Jun 10, 2018
092ec21
Wrap deno library in a namespace.
ry Jun 10, 2018
7c71785
deno.cc clean up
ry Jun 10, 2018
aa85798
Simplify c api
ry Jun 10, 2018
3062039
First pass at libdeno.
ry Jun 10, 2018
ff48eca
Expose deno::from_snapshot() constructor
ry Jun 10, 2018
12cded8
make_snapshot shouldn't depend on Deno object
ry Jun 10, 2018
a6880da
make_snapshot should be private
ry Jun 10, 2018
9296b21
Use C linkage in deno.h
ry Jun 10, 2018
c0401a4
Organize BUILD.gn
ry Jun 10, 2018
44e4190
deno_test.cc actually calls into deno now.
ry Jun 10, 2018
041e503
Minor libdeno clean ups.
ry Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deno2 Simplify Print binding.
  • Loading branch information
@ry
ry committed Jun 10, 2018
commit 9df9cdae07048564a9d81e9ea67159d49196a1df
18 changes: 5 additions & 13 deletions deno2/deno.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,12 @@ void ExitOnPromiseRejectCallback(
}

void Print(const v8::FunctionCallbackInfo<v8::Value>& args) {
bool first = true;
assert(args.Length() == 1);
auto* isolate = args.GetIsolate();
for (int i = 0; i < args.Length(); i++) {
v8::HandleScope handle_scope(isolate);
if (first) {
first = false;
} else {
printf(" ");
}
v8::String::Utf8Value str(isolate, args[i]);
const char* cstr = ToCString(str);
printf("%s", cstr);
}
printf("\n");
v8::HandleScope handle_scope(isolate);
v8::String::Utf8Value str(isolate, args[0]);
const char* cstr = ToCString(str);
printf("%s\n", cstr);
fflush(stdout);
}

Expand Down