Update to TypeScript 3.5.1 #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekth
reviewed
Jun 1, 2019
| const method: (...args: any[]) => any = searchParams[methodName]; | ||
| searchParams[methodName] = (...args: unknown[]): void => { | ||
| searchParams[methodName] = (...args: unknown[]): any => { |
There was a problem hiding this comment.
Why any as you don't return a value?
There was a problem hiding this comment.
There is an assignability issue in 3.5.1. Now TypeScript goes through each of the methodName values on searchParams and looks at the assignability, and some of those return things, so you can't assign a void to them. I don't know if the code is actually wrong or not, but now TypeScript is doing some real valid analysis. It is possible this method should really be returning something, but I just made a fix to get the code to pass under 3.5.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some minor changes because type analysis was more precise than previous versions and
globalThisneeded to be removed from the runtime type library, because it is provided by TypeScript itself.