Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): use primordials in ext/node/polyfills/testing.ts #24310

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix(ext/node): use primordials in ext/node/polyfills/testing.ts #24310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b9211e
fix(ext/node): use primordials in `ext/node/polyfills/testing.ts`
iuioiua Jun 22, 2024
1251db8
fmt
iuioiua Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fmt
  • Loading branch information
@iuioiua
iuioiua committed Jun 22, 2024
commit 1251db887c1cc9112179cd7c37a741d2a8df2fcf
25 changes: 14 additions & 11 deletions ext/node/polyfills/testing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,20 @@ class NodeTestContext {

test(name, options, fn) {
const prepared = prepareOptions(name, options, fn, {});
return PromisePrototypeThen(this.#denoContext.step({
name: prepared.name,
fn: async (denoTestContext) => {
const newNodeTextContext = new NodeTestContext(denoTestContext);
await prepared.fn(newNodeTextContext);
},
ignore: prepared.options.todo || prepared.options.skip,
sanitizeExit: false,
sanitizeOps: false,
sanitizeResources: false,
}), () => undefined);
return PromisePrototypeThen(
this.#denoContext.step({
name: prepared.name,
fn: async (denoTestContext) => {
const newNodeTextContext = new NodeTestContext(denoTestContext);
await prepared.fn(newNodeTextContext);
},
ignore: prepared.options.todo || prepared.options.skip,
sanitizeExit: false,
sanitizeOps: false,
sanitizeResources: false,
}),
() => undefined,
);
}

before(_fn, _options) {
Expand Down