Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): rewrite crypto.Hash #24302

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

lucacasonato
Copy link
Member

Changes in this PR:

  • Added new fixed size hash algorithms (blake2b512, blake2s256, sha512-224, sha512-256, sha3-224, sha3-256, sha3-384, sha3-512, sm3)
  • Added variable size hash algorithms (the concept), with the algorithms shake128 and shake256
  • Use cppgc instead of resources for the hasher
  • Enable Node's crypto.Hash tests and fix found bugs

Fixes #24219
Fixes #23987

Changes in this PR:

- Added new fixed size hash algorithms (blake2b512, blake2s256, sha512-224, sha512-256, sha3-224, sha3-256, sha3-384, sha3-512, sm3)
- Added variable size hash algorithms (the concept), with the algorithms shake128 and shake256
- Use cppgc instead of resources for the hasher
- Enable Node's crypto.Hash tests and fix found bugs
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@lucacasonato lucacasonato enabled auto-merge (squash) June 23, 2024 14:40
@lucacasonato lucacasonato merged commit 1e8a6b9 into denoland:main Jun 24, 2024
17 checks passed
@lucacasonato lucacasonato deleted the node_crypto branch June 24, 2024 09:48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
Changes in this PR:

- Added new fixed size hash algorithms (blake2b512, blake2s256,
sha512-224, sha512-256, sha3-224, sha3-256, sha3-384, sha3-512, sm3)
- Added variable size hash algorithms (the concept), with the algorithms
shake128 and shake256
- Use cppgc instead of resources for the hasher
- Enable Node's crypto.Hash tests and fix found bugs
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Changes in this PR:

- Added new fixed size hash algorithms (blake2b512, blake2s256,
sha512-224, sha512-256, sha3-224, sha3-256, sha3-384, sha3-512, sm3)
- Added variable size hash algorithms (the concept), with the algorithms
shake128 and shake256
- Use cppgc instead of resources for the hasher
- Enable Node's crypto.Hash tests and fix found bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants