Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): remove trailing slash from import.meta.dirname expected output #24295

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 20, 2024

import.meta.dirname behaves correctly, according to Node's implementation. Rather, the documentation simply had a typo.

Closes #24278

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit c012c20 into denoland:main Jun 21, 2024
17 checks passed
@iuioiua iuioiua deleted the import-meta-dirname-slash branch June 21, 2024 05:52
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import.meta.dirname doesn't include a trailing forward slash
2 participants