Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more node-api fixes #24220

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: more node-api fixes #24220

merged 1 commit into from
Jun 19, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jun 15, 2024 •
edited
Loading

  • add fallback impls of external string apis which always copy. after upstream changes to rusty_v8 we can support non-copying api as well.
  • napi_get_buffer_data needs to work on all TypedArray instances.
  • target_defaults.default_configuration is used by some modules to find the corresponding node file from node-gyp
  • node_api_get_module_filename expects the filename to be a file: url.

@bartlomieju
Copy link
Member

Could you add some regression tests for these changes?

@devsnek
Copy link
Member Author

devsnek commented Jun 16, 2024

I'm hoping to get the node-api test stuff i've been working on merged in the near future which should cover all of this.

lucacasonato
lucacasonato approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsnek devsnek merged commit 293a36f into main Jun 19, 2024
17 checks passed
@devsnek devsnek deleted the x/more-napi-fixes branch June 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some node api may be broken in 1.44.2 ?
3 participants
@devsnek @bartlomieju @lucacasonato