fix(npm): use more relaxed package.json version constraint parsing #24202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 13, 2024
| @@ -75,13 +75,13 @@ pub fn get_local_package_json_version_reqs( | |||
| }); | |||
| } | |||
| let (name, version_req) = parse_dep_entry_name_and_raw_version(key, value); | |||
| let result = VersionReq::parse_from_specifier(version_req); | |||
| let result = VersionReq::parse_from_npm(version_req); | |||
There was a problem hiding this comment.
Fix is here. I think this was just a mistake initially.
| @@ -2,7 +2,7 @@ | |||
| "name": "npmrc_test", | |||
| "version": "0.0.1", | |||
| "dependencies": { | |||
| "@denotest/basic": "1.0.0", | |||
| "@denotest/basic": "^=1.0.0", | |||
There was a problem hiding this comment.
I piggy-backed on a random test. It causes the more relaxed parsing to be hit.
dsherret
commented
Jun 13, 2024
| @@ -227,6 +227,26 @@ mod test { | |||
| ); | |||
| } | |||
There was a problem hiding this comment.
Oh, it looks like this was previously purposefully done, but we should try to be as npm compatible as possible.
bartlomieju
pushed a commit
that referenced
this pull request
Jun 18, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: