Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lsp): store settings in Arc #24191

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

nayeemrmn
Copy link
Collaborator

Namely Config::{settings,client_capabilities,workspace_folders} and some nested WorkspaceSettings. These are large and cloned often.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nayeemrmn nayeemrmn merged commit 518e4d3 into denoland:main Jun 13, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-settings-arc branch June 13, 2024 19:58
bartlomieju pushed a commit that referenced this pull request Jun 18, 2024
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants