fix(cli): Explicitly cache NPM packages during deno install
#24190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jun 12, 2024
dsherret
reviewed
Jun 12, 2024
| @@ -75,6 +75,9 @@ pub async fn load_top_level_deps(factory: &CliFactory) -> Result<(), AnyError> { | |||
| let npm_resolver = factory.npm_resolver().await?; | |||
| if let Some(npm_resolver) = npm_resolver.as_managed() { | |||
| npm_resolver.ensure_top_level_package_json_install().await?; | |||
| // TODO(nathanwhit): we call `cache_packages` if the lockfile is modified, | |||
| // so by calling it here it's possible we end up calling it twice | |||
| npm_resolver.cache_packages().await?; | |||
There was a problem hiding this comment.
It should be doing this within ensure_top_level_package_json_install. Does it not happen?
There was a problem hiding this comment.
Ah, I see:
if reqs
.iter()
.all(|req| self.resolution.resolve_pkg_id_from_pkg_req(req).is_ok())
{
log::debug!(
"All package.json deps resolvable. Skipping top level install."
);
return Ok(()); // everything is already resolvable
}
nathanwhit
added a commit
that referenced
this pull request
Jun 13, 2024
Fixes a regression introduced in #24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules.
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
…nd#24190) Fixes a regression introduced in denoland#24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #24170, where we wouldn't actually set up the node modules dir on
deno installif there was an up to date deno lockfile present.Previously we were relying on the fact that resolving pending module resolution called
cache_packages(which sets up the node modules dir). When pending resolutions were removed, and theresolve_pendingfunction with it, we also removed thecache_packagescall needed to set up node modules.