Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): strip .js before probing for valid import fix #24188

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix(lsp): strip .js before probing for valid import fix #24188

merged 1 commit into from
Jun 12, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #23017.

dsherret
dsherret approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit b30e5c0 into denoland:main Jun 12, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-quickfix-import-fix branch June 12, 2024 22:47
nathanwhit pushed a commit that referenced this pull request Jun 13, 2024
@nayeemrmn @nathanwhit
fix(lsp): strip .js before probing for valid import fix (#24188)
5bc78de
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@nayeemrmn @zebreus
fix(lsp): strip .js before probing for valid import fix (denoland#24188)
49199a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: import suggestion imports .d.ts file as .js
2 participants
@nayeemrmn @dsherret