Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): don't sort workspace files #24180

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

nayeemrmn
Copy link
Collaborator

This stops nested deno.jsons from being added to the tree before their parents. This would break workspaces for subdirs with names preceding deno.json, but it's not observable yet.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 3b9eeba into denoland:main Jun 11, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-workspace-files-unsort branch June 11, 2024 20:07
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants