-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compile): support --env #24166
Merged
Merged
feat(compile): support --env #24166
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
33cc111
fix: Added support for --env for the compile subcommand
HasanAlrimawi c72851e
update: repetitive code wrapped into a function to be reused without …
HasanAlrimawi 4b48e42
Merge branch 'main' into compile-env-support
HasanAlrimawi 57c2a76
Merge branch 'main' into compile-env-support
HasanAlrimawi 3dbf249
lint-fix: replaced eprintln with log::info & initialized logging syst…
HasanAlrimawi 5ee011b
Merge branch 'main' into compile-env-support
HasanAlrimawi a6be904
removed unsused import
HasanAlrimawi 92d2967
Merge branch 'main' into compile-env-support
HasanAlrimawi d1c5efb
Merge branch 'main' into compile-env-support
HasanAlrimawi 64cc593
Merge branch 'main' into compile-env-support
HasanAlrimawi b3be35f
Merge branch 'main' into compile-env-support
HasanAlrimawi 1f8c1a6
Merge branch 'main' into compile-env-support
HasanAlrimawi 6ec532a
Merge branch 'main' into compile-env-support
HasanAlrimawi fa99ddd
Merge branch 'main' into compile-env-support
HasanAlrimawi 8df79fa
Merge branch 'main' into compile-env-support
HasanAlrimawi 97c1f01
Merge branch 'main' into compile-env-support
HasanAlrimawi 9b3ad26
fix: append env file variables into executable
HasanAlrimawi 49b42ad
fix: added log and updated test .out file
HasanAlrimawi d6065ac
Merge branch 'main' into compile-env-support
HasanAlrimawi 04e4b3e
Merge branch 'main' into compile-env-support
HasanAlrimawi 6d2ec5c
Merge branch 'main' into compile-env-support
HasanAlrimawi 65111fd
Merge branch 'main' into compile-env-support
HasanAlrimawi c1f9440
Merge branch 'main' into compile-env-support
HasanAlrimawi e33d836
Merge branch 'main' into compile-env-support
HasanAlrimawi 670067c
Updates
dsherret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lint-fix: replaced eprintln with log::info & initialized logging syst…
…em for generated executable file
- Loading branch information
commit 3dbf249ef345231ffbf0ca5cab84f06e9705892c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just looking at this PR in detail. I'm not so sure about just providing a reference to the file because the file won't necessarily exist at runtime. Probably we need to embed the env variables into the executable and warn that we're doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
I'll sort it out according to your vision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dsherret ,
I made changes to embed the env variables from the env file into the generated executable and to warn the user about this action.
When running the executable, it will load the embedded variables as env variables.