FUTURE: support deno install <alias>@npm:<package>
#24156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jun 10, 2024
Comment on lines
+546
to
+552
| assert_eq!( | ||
| AddPackageReq::parse("@alias/pkg@jsr:foo").unwrap(), | ||
| AddPackageReq { | ||
| alias: "@alias/pkg".to_string(), | ||
| value: AddPackageReqValue::Jsr(PackageReq::from_str("foo").unwrap()) | ||
| } | ||
| ); |
There was a problem hiding this comment.
What about alias@jsr:foo@^1.5.0? Is it handled here? If not can you add a test that expects it to fail?
There was a problem hiding this comment.
That will succeed and then fail on download. I added a test for it succeeding.
There was a problem hiding this comment.
Why will it fail on download?
There was a problem hiding this comment.
Because it's not a scoped package.
dsherret
changed the title
deno install <alias>@npm:<package>deno install <alias>@npm:<package>
nathanwhit
pushed a commit
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23144