fix(check): attempt to resolve types from pkg before @types pkg
#24152
+96
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 8, 2024
There was a problem hiding this comment.
Main:
---- specs::npm::check_prefers_non_types_node_pkg ----
command V:\deno\target\debug\deno.exe check --quiet main.ts
command cwd V:\deno\tests\specs\npm\check_prefers_non_types_node_pkg
panicked at tests\specs/mod.rs:393:12:
assertion failed: `(left == right)`
Diff < left / right > :
<error: Failed resolving types. Cannot find "lz-string"
< at file:https:///V:/deno/tests/specs/npm/check_prefers_non_types_node_pkg/main.ts:1:47
<
lucacasonato
approved these changes
Jun 9, 2024
nathanwhit
pushed a commit
that referenced
this pull request
Jun 13, 2024
…4152) I've been meaning to fix this for ages, but I finally ran into it here: https://github.com/dsherret/ts-ast-viewer/actions/runs/9432038675/job/25981325408 We need to resolve the `@types` package as a fallback instead of eagerly resolving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been meaning to fix this for ages, but I finally ran into it here:
https://github.com/dsherret/ts-ast-viewer/actions/runs/9432038675/job/25981325408
We need to resolve the
@typespackage as a fallback instead of eagerly resolving it.