fix(ext/node): lossy UTF-8 read node_modules files #24140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Jun 7, 2024
Comment on lines
+323
to
+328
| let code = match String::from_utf8_lossy(&code) { | ||
| Cow::Owned(code) => code, | ||
| // SAFETY: `String::from_utf8_lossy` guarantees that the result is valid | ||
| // UTF-8 if `Cow::Borrowed` is returned. | ||
| Cow::Borrowed(_) => unsafe { String::from_utf8_unchecked(code) }, | ||
| }; |
There was a problem hiding this comment.
It's surprising there isn't a version of this on String.
There was a problem hiding this comment.
Yeah... I have to reimplement this helper frequently 🥲
Maybe I should make a PR to the standard library.
b6968fc
to
4c13694
Compare
nathanwhit
pushed a commit
that referenced
this pull request
Jun 13, 2024
Previously various reads of files in `node_modules` would error on invalid UTF-8. These were cases involving: - reading package.json from Rust - reading package.json from JS - reading CommonJS files from JS - reading CommonJS files from Rust (for ESM translation) - reading ESM files from Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously various reads of files in
node_moduleswould error on invalid UTF-8. These were cases involving:There are tests for all these cases now.
Fixes #24027
Needs denoland/deno_core#773 to land first.