Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): use configured auth for tarball urls instead of scope auth #24111

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 5, 2024

Deno was using the scope auth for the tarball urls, which is not always correct. We are going to do a release immediately for this issue.

@dsherret dsherret requested a review from bartlomieju June 5, 2024 20:56
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍

Comment on lines +186 to +189
"No auth for tarball URI, but present for scoped registry.\n\n",
"Tarball URI: {}\n",
"Scope URI: {}\n\n",
"More info here: https://github.com/npm/cli/wiki/%22No-auth-for-URI,-but-auth-present-for-scoped-registry%22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@dsherret dsherret enabled auto-merge (squash) June 5, 2024 21:14
@dsherret dsherret merged commit 566adb7 into denoland:main Jun 5, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix_npm_auth_for_tarballs branch June 5, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants