refactor(npm): improve locking around updating npm resolution #24104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd some other issues.
dsherret
commented
Jun 5, 2024
| let downloader = self.clone(); | ||
| let name = name.to_string(); | ||
| Box::new(move || downloader.create_load_future(&name)) | ||
| }); |
There was a problem hiding this comment.
Improved this to get a function in the constructor that creates the furture.
dsherret
commented
Jun 5, 2024
dsherret
commented
Jun 5, 2024
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { |
dsherret
commented
Jun 5, 2024
| retry_index: 0, | ||
| future: None, | ||
| }), | ||
| create_future, |
There was a problem hiding this comment.
This now stores a function for creating the future.
dsherret
commented
Jun 5, 2024
bartlomieju
reviewed
Jun 5, 2024
| } | ||
|
|
||
| #[test] | ||
| fn multi_runtimes_first_never_finishes() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
SyncReadAsyncWriteLockto make it harder to write to the npm resolution without first waiting async in a queue. For the npm resolution, reading synchronously is fine, but when updating, someone should wait async, clone the data, then write the data at the end back.