Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync up Node.js test files for v20.11.1 #24066

Merged
merged 23 commits into from
Jun 11, 2024
Merged

chore: sync up Node.js test files for v20.11.1 #24066

merged 23 commits into from
Jun 11, 2024

Conversation

bartlomieju
Copy link
Member

No description provided.

devsnek
devsnek approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming nothing explodes

@kt3k
Copy link
Member

kt3k commented Jun 2, 2024 •
edited
Loading

Now 11 cases are failing (because of the upstream changes):

  • "parallel/test-buffer-tostring-rangeerror.js"
  • "parallel/test-console-table.js"
  • "parallel/test-fs-read.js"
  • "parallel/test-fs-write-file-sync.js"
  • "parallel/test-path-parse-format.js"
  • "parallel/test-stream-buffer-list.js"
  • "parallel/test-stream-uint8array.js"
  • "parallel/test-stream-writable-decoded-encoding.js"
  • "parallel/test-stream-writable-end-cb-error.js"
  • "parallel/test-stream2-readable-from-list.js"
  • "parallel/test-stream2-writable.js"

@kt3k kt3k self-assigned this Jun 7, 2024
kt3k
kt3k approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved all issues which seem caused by upstream changes. LGTM

@bartlomieju
Copy link
Member Author

Thank you @kt3k, much appreciated!

@bartlomieju bartlomieju enabled auto-merge (squash) June 11, 2024 11:15
@bartlomieju bartlomieju merged commit 6a356af into denoland:main Jun 11, 2024
17 checks passed
@bartlomieju bartlomieju deleted the update_node_test branch June 11, 2024 13:13
nathanwhit pushed a commit that referenced this pull request Jun 13, 2024
@bartlomieju @kt3k @nathanwhit
chore: sync up Node.js test files for v20.11.1 (#24066)
03436e8 
Co-authored-by: Yoshiya Hinosawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@devsnek devsnek devsnek approved these changes

Assignees

@kt3k kt3k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @kt3k @devsnek